Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external JavaScript file #54

Closed
wants to merge 6 commits into from
Closed

Add support for external JavaScript file #54

wants to merge 6 commits into from

Conversation

yuxiaoy1
Copy link
Collaborator

Fix #13

@yuxiaoy1 yuxiaoy1 requested a review from greyli May 16, 2021 05:21
@yuxiaoy1
Copy link
Collaborator Author

Not sure if there is a better way addressing the issue, please review.
Ps. I've added a static folder in the project root directory for test purpose, this is absolutely not a best practice, we may need create another PR to restructure the test file under a tests folder.

@greyli
Copy link
Member

greyli commented May 16, 2021

we may need create another PR to restructure the test file under a tests folder.

Yep, this project needs a huge refactor. I'm considering a 2.0 version (drop Python 2 support, remove deprecated codes, etc). For now, I think we need to make the building work first. I currently have no time to test this, maybe review it next week.

@yuxiaoy1 yuxiaoy1 closed this by deleting the head repository Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: extend Dropzone embedded script
2 participants